C library: add __to{lower,upper} as alternative names for {tolower,toupper} #8283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
…upper} macOS eventually calls a function called `__tolower` (`__toupper`). Rename our previous implementation to `__CPROVER_tolower` (`__CPROVER_toupper`) and make both `tolower` (`toupper`) and `__tolower` (`__toupper`) use this. Also enable their regression tests.
tautschnig
force-pushed
the
features/tolower
branch
from
4622ed5 to
98d09fb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8283 +/- ##
========================================
Coverage 77.55% 77.55%
========================================
Files 1721 1721
Lines 190128 190128
Branches 18438 18438
========================================
Hits 147448 147448
Misses 42680 42680 ☔ View full report in Codecov by Sentry. |
kroening
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS eventually calls a function called
__tolower(__toupper). Rename our previous implementation to__CPROVER_tolower(__CPROVER_toupper) and make bothtolower(toupper) and__tolower(__toupper) use this. Also enable their regression tests.